Remove index sync feature flag #6375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Turbo87
force-pushed
the
remove-index-sync-feature-flag
branch
3 times, most recently
from
7bfaac3 to
6c771c6
Compare
|
☔ The latest upstream changes (presumably #6380) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
remove-index-sync-feature-flag
branch
from
6c771c6 to
aef34fe
Compare
|
☔ The latest upstream changes (presumably #6267) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
remove-index-sync-feature-flag
branch
from
aef34fe to
92c9532
Compare
This has been enabled in production now, so we can remove the feature flag.
This has been replaced by the two `SyncToGit/SparseIndex` jobs
This has been replaced by the two `SyncToGit/SparseIndex` jobs
This has been replaced by the two `SyncToGit/SparseIndex` jobs
Turbo87
force-pushed
the
remove-index-sync-feature-flag
branch
from
92c9532 to
cb22eb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
FEATURE_INDEX_SYNCfeature flag.I've opened this as a draft PR since we just enabled the feature flag this morning and we should probably wait with the removal for 1-2 weeks until we are confident that enabling the flag did not unintentionally break anything.